refactor(ci): Use separate job for postgres ssl auth tests #3977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Potts <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Postgres CI job more reliable by splitting the Postgres GitHub workflow job into two jobs which use their own separate docker container, instead of the current situation where one job attempts to tear down the container used by previous steps, and start a new one bound to the same host port.
Prevents bind failures.
Also fixes a deprecation warning by removing the deprecated
versionfield from the docker compose file.This pr is a cherry pick out of #3950.
Does your PR solve an issue?
Prevents CI failures caused by bind failures during the creation of the Postgres container used for testing SSL based authentication.
Is this a breaking change?
No - only changes the GitHub workflow and another file used by tests.